fix: flush stdout after writes for real-time RPC notifications#50
Open
zerone0x wants to merge 1 commit intosteipete:mainfrom
Open
fix: flush stdout after writes for real-time RPC notifications#50zerone0x wants to merge 1 commit intosteipete:mainfrom
zerone0x wants to merge 1 commit intosteipete:mainfrom
Conversation
Adds synchronize() call after stdout writes to prevent buffering delays. Without explicit flushing, Swift's FileHandle.standardOutput buffers writes until the buffer fills (~4-8KB). This causes RPC notifications to be delayed by 3-9 minutes in low-traffic scenarios, as small JSON messages (~200-500 bytes) accumulate in the buffer. The fix ensures immediate delivery of watch notifications to clients. Fixes steipete#23 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23
Adds
synchronize()call after stdout writes to prevent buffering delays in RPC notifications.Problem
Swift's
FileHandle.standardOutputbuffers writes by default. Without explicit flushing, RPC notifications accumulate in the buffer (~4-8KB) and are delayed by 3-9 minutes in low-traffic scenarios.As described in the issue:
Solution
Add
try? FileHandle.standardOutput.synchronize()after each write inStdoutWriter.writeLine():Testing
This fix ensures
imsg rpcwatch notifications are delivered immediately, matching the real-time behavior of the underlying FSEvents watcher.🤖 Generated with Claude Code