Fix shell completions by recognizing Cobra's internal commands #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maybeDefaultToSpeak() function was intercepting __complete and __completeNoDesc commands that Cobra uses internally for shell completions. This caused completions to fail silently. Add these hidden commands to isCobraBuiltin() so they pass through to Cobra's completion handler. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Shell completions generated by
sag completion fish|bash|zshweren't working becausemaybeDefaultToSpeak()was intercepting Cobra's internal completion commands (__completeand__completeNoDesc).The problem
When you type
sag speak -v <TAB>, the shell runs something like:But
maybeDefaultToSpeak()didn't recognize__completeas a builtin, so it rewrote this to:Which breaks completions entirely.
The fix
Add
__completeand__completeNoDesctoisCobraBuiltin()so they pass through to Cobra's completion handler.Test plan
__completeand__completeNoDesc🤖 Generated with Claude Code