Skip to content

Conversation

@joelbdavies
Copy link
Contributor

The v1/voices API does not support the search query parameter, so searching for a voice by name (e.g., -v sarah) would return all voices and then incorrectly use the first unrelated voice as a "closest match".

Changes:

  • ListVoices now filters results client-side by name substring
  • resolveVoice checks for exact match first, then substring match
  • Returns an error if no matching voice found instead of using an unrelated voice
  • Updated tests to verify actual name matching (not just first result)

@steipete
Copy link
Owner

Thanks for the contribution, Joel!

steipete added a commit to joelbdavies/sag that referenced this pull request Jan 24, 2026
steipete added a commit to joelbdavies/sag that referenced this pull request Jan 24, 2026
@steipete steipete force-pushed the fix/client-side-voice-filtering branch from 07819ba to f86b245 Compare January 24, 2026 04:47
@steipete steipete force-pushed the fix/client-side-voice-filtering branch from f86b245 to 586afa0 Compare January 24, 2026 04:52
@steipete steipete merged commit 16a39fe into steipete:main Jan 24, 2026
@steipete
Copy link
Owner

Landed via temp rebase onto main.\n\n- Gate: pnpm lint && pnpm build && pnpm test\n- Land commit: 586afa0\n- Merge commit: 16a39fe\n\nThanks @joelbdavies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants