Add system keychain support for secure API key storage #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `sag keychain set/get/delete` commands for storing the ElevenLabs API key in the system keychain. Supports macOS Keychain, Windows Credential Manager, and Linux Secret Service (GNOME Keyring). The keychain is checked after --api-key-file but before environment variables, providing a more secure alternative to storing keys in plain text files or environment variables. Closes steipete#6 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
Marking as draft for now - I'll review the code Claude generated this afternoon and continue working on it if everything looks good. |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
For security, don't expose a command that prints the API key - a compromised agent could extract it. Instead, provide a status command that only reports whether a key is stored. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sag keychain set/status/deletecommands for storing the ElevenLabs API key securely in the system keychainSecurity note: The
statuscommand only reports whether a key is stored, not its value - prevents compromised agents from extracting the key.Priority order
The keychain is checked after
--api-key-filebut before environment variables:--api-keyflag--api-key-fileflag /ELEVENLABS_API_KEY_FILEenv varsELEVENLABS_API_KEY/SAG_API_KEYenv varsTest plan
Closes #6
🤖 Generated with Claude Code