Fix missing artists in Connect track info #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Connect getTrack only surfaced the first artist; otherArtists (e.g., remixers) were ignored. Solution: parse otherArtists in trackUnion and tighten artist name extraction to avoid unrelated names; add tests for firstArtist/otherArtists containers.
Problem: some Connect artist fragments only include id+name, so artistNameFromValue ignored them. Solution: treat id as sufficient evidence of an artist map and add a regression test.
## Overview
This PR fixes track info to return all credited artists when using the Connect GraphQL payload.
## Changes
- Parse `trackUnion.otherArtists` alongside `firstArtist`
- Treat `{id, name}` artist fragments as valid without reintroducing unrelated names
- Add regression tests for `firstArtist`, `otherArtists`, and id+name fragments
## Rationale
- Connect `getTrack` responses often wrap artists in container shapes (`artists.items`, `firstArtist`, `otherArtists`). We only handled flat arrays and `artistName`, so artists were missing entirely and
secondary artists (remixers/collabs) were ignored. Some payloads also return minimal artist fragments (`id`, `name`) which were being filtered out.
## Testing
- `go test ./internal/spotify`
- tested a range of different tracks, which previously returned no artists; now succeeds!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes track info to return all credited artists when using the Connect GraphQL payload.
Changes
trackUnion.otherArtistsalongsidefirstArtist{id, name}artist fragments as valid without reintroducing unrelated namesfirstArtist,otherArtists, and id+name fragmentsRationale
getTrackresponses often wrap artists in container shapes (artists.items,firstArtist,otherArtists). We only handled flat arrays andartistName, so artists were missing entirely andsecondary artists (remixers/collabs) were ignored. Some payloads also return minimal artist fragments (
id,name) which were being filtered out.Testing
go test ./internal/spotifyspogo track info spotify:track:06tI2UeECYQN6AM4mZkB5s --json { "id": "06tI2UeECYQN6AM4mZkB5s", "uri": "spotify:track:06tI2UeECYQN6AM4mZkB5s", "name": "Alive - SG Lewis Remix", "type": "track", "url": "https://open.spotify.com/track/06tI2UeECYQN6AM4mZkB5s", "artists": [ "Empire Of The Sun", "SG Lewis" ], "album": "Alive (SG Lewis Remix)" }