[FEATURE] Adds support for icons from token lists

[aristidesstaffieri]

Closes #1791

What
Adds an API level lookup for icon URLs from any active token lists in order to support icons from tokens that don't have a home domain( like SEP-41 tokens, USDL, etc. ).

Why
SEP-41 tokens currently have no support for icons but its possible for them to be added to community token lists with a corresponding icon URL.

Related:
Adds USDL to Soroswap's token list
https://github.com/soroswap/token-list/pull/55/files

[aristidesstaffieri]

I removed the schema validation because both Soroswap and Lobstr have lists that we want to use but due to slight differences they don't align with the spec. We need Soroswap's list in order for this feature to work and the schema differences are small(bad version schema and use mainnet instead of pubnet).

These differences are inconsequential to the way we use them and our use of the lists checks for string equality on specific fields, so it should be fine to not validate the lists since these equality checks will fail if the fields are not present resulting in the same behavior as an earlier failure due to schema validation.

I can work with those teams to update their lists to match validation separately.

[CassioMG]

good list name 💯

[CassioMG]

suggestion: should we have separate contractId and issuerKey params and let the function return whatever it finds giving priority to contractId? So we don't need to call it twice and await twice like it's happening here.

Then this getIconFromTokenLists function could return something like { icon, canonicalAsset } so we could use canonicalAsset as the icon key for assetIcons.

I think having contractId and issuerKey params would also make the function declaration a bit easier to understand since we'd be removing the ambiguity.

What do you think?

[aristidesstaffieri]

I updated it to use your suggested pattern, I also pass in the code from the caller because its safer to take the code from the extension to make the canonical vs assuming the code from the token list will match. Wdyt?
e16ae43

[CassioMG]

thanks for the update, looks good to me!

[CassioMG]

LGTM! Left a suggestion regarding the function inputs and response

Thanks for moving/extracting stuff to @shared/api so it'll be easier to reuse on the mobile wallet! 👊