services/galexie: Add scan-and-replace (overwrite) command. #5826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urvisavla
requested review from
sreuland and
tamirms
and removed request for
sreuland
sreuland
reviewed
Oct 17, 2025
sreuland
reviewed
Oct 17, 2025
sreuland
reviewed
Oct 17, 2025
sreuland
reviewed
Oct 17, 2025
sreuland
reviewed
Oct 17, 2025
sreuland
approved these changes
Oct 17, 2025
tamirms
reviewed
Oct 18, 2025
| _ Mode = iota | ||
| ScanFill Mode = iota | ||
| Append | ||
| ScanReplace |
There was a problem hiding this comment.
not a big deal for me but I would prefer the command to be called replace, overwrite, or rewrite instead of scan-and-replace
tamirms
reviewed
Oct 18, 2025
| scanAndFillCmd.PersistentFlags().AddFlagSet(commonFlags) | ||
| viper.BindPFlags(scanAndFillCmd.PersistentFlags()) | ||
|
|
||
| scanAndReplaceCmd.PersistentFlags().AddFlagSet(commonFlags) |
There was a problem hiding this comment.
nit: I think we can use the common flags in the other commands as well
tamirms
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add a new command
scan-and-replaceto re-export of all ledgers within a specified range, overwriting any existing data in the data lake. It is restricted to bounded mode.Why
#5514
Known limitations
The command uses a single PutFile operation and does not check for the existence. So, the uploader cannot distinguish between a new file and an overwritten one. Therefore, for metrics logging label
already_existswill always be recorded as false.