Remove need for Copy on error enums #1292
Open
+464
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the title
leighmcculloch
commented
Sep 20, 2024
Comment on lines
-147
to
+148
| Ok((*self as u32).into()) | ||
| Ok(match self { | ||
| #(#try_intos,)* | ||
| }) |
There was a problem hiding this comment.
This optimisation doesn't matter, it's in testutils, it doesn't impact wasm builds.
dmkozh
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove need for Copy/Clone/etc on error enums and int enums.
Why
Less compiler errors for folks just getting started.
The generated code currently requires that error enums impl the Copy trait because they use a copy within. That copy is unnecessary and this change removes it, removing the need for Copy to be derived on error enums.
I was confident that the copy had been put there as an optimisation, but when I looked into the code that was relying on it I found not optimisation was in use. When I tried to add the optimisation, I couldn't find a contract size difference.
A while ago we in #1293 added better error messages for needing copy, which was a good fix at the time, I just think we can remove the need for this all together.
Close #630