Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testutils invoke with incorrect arg count #1336

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

leighmcculloch
Copy link
Member

What

Panic if the number of args being passed to a natively registered contract don't match the number of args the contract function expects.

Why

This bug exists only in the testutils path of invoking a natively registered contract and does not impact WASM registered contracts, or the env as deployed.

If a native contract is invoked with too few arguments, a panic occurs with an index out of bounds errors that is not intuitive to debug. The panic displayed to the developer should be as intuitive as possible.

  • Before: index out of bounds: the len is 1 but the index is 1
  • After: invalid number of input arguments: 2 expected, got 1

If a native contract is invoked with too many arguments, no panic occurs, the additional arguments are simply ignored. The behaviour of invoking natively registered contracts in testutils should be as consistent as possible to invoking contracts on a deployed network. In both of these cases the invoke fails.

  • Before: no panic
  • After: invalid number of input arguments: 2 expected, got 3

Thanks to @dmkozh who fixed this bug and proposed the better error experience in #1327 which is destined for the next major release of the sdk v22, and this pull request extracts the fix in isolation so we can release a bug fix release of the sdk v21.

This fix is extracted from #1327 by @dmkozh.

Co-authored-by: Dmytro Kozhevin <dmytro@stellar.org>
@dmkozh dmkozh added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 64c1645 Sep 16, 2024
16 checks passed
@dmkozh dmkozh deleted the blockiness-encastage branch September 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants