Fix warnings on contract and contractimpl macros #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix and disable warnings on contract and contractimpl macros for misformatted item names, and missing fns.
Why
Starting with the last release warnings started to display on the contract and contractimpl macros because of generated code not following the naming conventions for some items.
In one case it is easier to fix the naming convention, and so that is what was done.
In the other case it is easier to silence the warning, and so that is what was done.
One of the warnings was about a missing function. In this case I think there's an issue with rust-analyzer and how we were generating two dependent parts of code different ways. In one are we were always generating the code feature gated, in the other we were generating it only based on the feature. Rust-analyzer doesn't rebuild proc-macros frequently, and so I think caching of generated code that then had the feature off was to blame.
Backporting
This change should be backported to the 21 versions as a patch on 21.7 after merging to main.