Add conversion from references of tuples to ScVal #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add impls of TryFrom for references of tuples to ScVec and ScVal.
Why
Per stellar/rs-soroban-sdk#1124, UDTs currently don't work with tuple fields because the
#[contracttype]macro generates code that expects theFromimplementation on references of the types it is converting.Known limitations
None, but because this enables more forms of UDTs to work, this will impose more requirements on client bindings for non-Rust languages.
I have tested the SDK with this patch applied, that UDTs with tuple fields work. After the SDK is updated for these changes I will land corresponding test cases in the SDK based on this patch: brson/rs-soroban-sdk@bcda4fa