Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDP-1374] Integrate Wallet Address in Processing Disbursement Instructions #453

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[SDP-1374] Integrate Wallet Address in Processing Disbursement Instructions #453

merged 1 commit into from
Nov 5, 2024

Conversation

marwen-abid
Copy link
Collaborator

@marwen-abid marwen-abid commented Oct 31, 2024 •
edited
Loading

What

Add support for Known Wallet Address processing when posting disbursement instructions.

Why

Support Known wallet addresses

Checklist

PR Structure

  • This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR title and description are clear enough for anyone to review it.
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@marwen-abid marwen-abid self-assigned this Oct 31, 2024
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests October 31, 2024 15:59 — with GitHub Actions Inactive
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) October 31, 2024 15:59 — with GitHub Actions Failure
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) October 31, 2024 15:59 — with GitHub Actions Inactive
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) October 31, 2024 15:59 — with GitHub Actions Error
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests (Circle) October 31, 2024 15:59 — with GitHub Actions Error
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr453.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr453.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr453.previews.kube001.services.stellar-ops.com

marcelosalloum
marcelosalloum reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, we're on the right track!

internal/data/disbursement_instructions.go Outdated Show resolved Hide resolved
internal/data/receivers.go Outdated Show resolved Hide resolved
@marcelosalloum marcelosalloum force-pushed the feat/SDP-1370-disbursement-stores-receiver-contact-type branch 5 times, most recently from 71e8c0a to f30bd2b Compare November 1, 2024 17:41
Base automatically changed from feat/SDP-1370-disbursement-stores-receiver-contact-type to develop November 1, 2024 17:56
@marwen-abid marwen-abid force-pushed the feat/SDP-1374-add-wallet-address-to-process-instructions branch from 7485a6b to 0afa42a Compare November 1, 2024 21:57
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests November 1, 2024 21:57 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 1, 2024 21:57 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 1, 2024 21:57 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 1, 2024 21:57 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Circle) November 1, 2024 21:57 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr453.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr453.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr453.previews.kube001.services.stellar-ops.com

@marwen-abid marwen-abid force-pushed the feat/SDP-1374-add-wallet-address-to-process-instructions branch from 0afa42a to 775240e Compare November 1, 2024 23:00
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 1, 2024 23:00 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests November 1, 2024 23:00 — with GitHub Actions Inactive
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) November 1, 2024 23:00 — with GitHub Actions Failure
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) November 1, 2024 23:00 — with GitHub Actions Error
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests (Circle) November 1, 2024 23:00 — with GitHub Actions Error
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr453.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr453.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr453.previews.kube001.services.stellar-ops.com

@marwen-abid marwen-abid force-pushed the feat/SDP-1374-add-wallet-address-to-process-instructions branch from 775240e to d1fb675 Compare November 4, 2024 18:33
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 4, 2024 18:33 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests November 4, 2024 18:33 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 4, 2024 18:33 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 4, 2024 18:33 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Circle) November 4, 2024 18:33 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr453.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr453.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr453.previews.kube001.services.stellar-ops.com

@marwen-abid marwen-abid force-pushed the feat/SDP-1374-add-wallet-address-to-process-instructions branch from d1fb675 to 09ac9c0 Compare November 4, 2024 22:57
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 4, 2024 22:57 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests November 4, 2024 22:57 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 4, 2024 22:57 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 4, 2024 22:57 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Circle) November 4, 2024 22:57 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr453.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr453.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr453.previews.kube001.services.stellar-ops.com

@marwen-abid marwen-abid force-pushed the feat/SDP-1374-add-wallet-address-to-process-instructions branch from 09ac9c0 to 0047045 Compare November 5, 2024 00:48
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 5, 2024 00:48 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 5, 2024 00:48 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 5, 2024 00:48 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests November 5, 2024 00:48 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Circle) November 5, 2024 00:48 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr453.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr453.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr453.previews.kube001.services.stellar-ops.com

@marwen-abid marwen-abid marked this pull request as ready for review November 5, 2024 00:50
marcelosalloum
marcelosalloum approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

internal/serve/httphandler/disbursement_handler.go Show resolved Hide resolved
internal/data/receivers_wallet.go Show resolved Hide resolved
internal/data/disbursement_instructions_test.go Show resolved Hide resolved
@marwen-abid marwen-abid merged commit 52e0a4d into develop Nov 5, 2024
16 checks passed
@marwen-abid marwen-abid deleted the feat/SDP-1374-add-wallet-address-to-process-instructions branch November 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelosalloum marcelosalloum marcelosalloum approved these changes

Assignees

@marwen-abid marwen-abid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marwen-abid @stellar-jenkins @marcelosalloum