services: rpc payment ingestor #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "ingest", | ||
| Short: "Run Ingestion service", | ||
| PersistentPreRunE: func(cmd *cobra.Command, args []string) error { | ||
| // SET UP WEBHOOK CHANNEL HERE |
Comment on lines
+69
to
+70
| PersistentPostRun: func(_ *cobra.Command, _ []string) { | ||
| }, |
There was a problem hiding this comment.
Why do we need this?
Comment on lines
+134
to
+143
| func RPCURLOption(configKey *string) *config.ConfigOption { | ||
| return &config.ConfigOption{ | ||
| Name: "rpc-url", | ||
| Usage: "The URL of the RPC Server.", | ||
| OptType: types.String, | ||
| ConfigKey: configKey, | ||
| FlagDefault: "localhost:8080", | ||
| Required: true, | ||
| } | ||
| } |
There was a problem hiding this comment.
What do you think about validating if the value passed here is a URL using the CustomSetValue?
| if txMemo != nil { | ||
| *txMemo = utils.SanitizeUTF8(*txMemo) | ||
| } | ||
|
|
||
| for idx, op := range tx.Envelope.Operations() { | ||
| txEnvelopeXDR.SourceAccount() |
There was a problem hiding this comment.
Perhaps we can remove this line.
| txns, err := ingestService.GetLedgerTransactions(1) | ||
| assert.Equal(t, 1, len(txns)) | ||
| assert.Equal(t, txns[0].Hash, "hash1") | ||
| assert.Empty(t, err) |
There was a problem hiding this comment.
Suggested change
| assert.Empty(t, err) | |
| assert.NoError(t, err) |
| @@ -52,8 +56,33 @@ func (r *rpcService) GetTransaction(transactionHash string) (entities.RPCGetTran | |||
| return result, nil | |||
| } | |||
|
|
|||
| func (r *rpcService) GetTransactions(startLedger int64, startCursor string, limit int) (entities.RPCGetTransactionsResult, error) { | |||
| if limit > PageLimit { | |||
| return entities.RPCGetTransactionsResult{}, fmt.Errorf("limit cannot exceed") | |||
There was a problem hiding this comment.
Perhaps we can add a limit to the error to make it clearer.
| ) | ||
|
|
||
| type RPCTXCode struct { | ||
| TxResultCode xdr.TransactionResultCode | ||
| OtherCodes OtherCodes | ||
| } | ||
|
|
||
| var FinalErrorCodes = []xdr.TransactionResultCode{ | ||
| xdr.TransactionResultCodeTxSuccess, |
There was a problem hiding this comment.
Why is this value on FinalErrorCodes slice?
There was a problem hiding this comment.
Perhaps we can rename it to FinalCodes only or FinalStateCodes.
| account := op.SourceAccount | ||
| if account != nil { | ||
| return account.ToAccountId().Address() | ||
| } | ||
|
|
||
| return tx.Envelope.SourceAccount().ToAccountId().Address() | ||
| txEnvelope.SourceAccount() |
There was a problem hiding this comment.
Perhaps we can remove this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pr replaces the ingestion of payments with a getTransactions RPC call
Why
We are removing all dependency on core in the wallet bakend, replacing it with rpc instead
Known limitations
N/A
Issue that this PR addresses
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release