all: Accounting for protocol 22 related RPC changes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamp-stellar
changed the title
aditya1702
reviewed
Oct 31, 2024
| @@ -31,6 +31,7 @@ type RPCGetTransactionResult struct { | |||
| OldestLedger int64 `json:"oldestLedger"` | |||
| OldestLedgerCloseTime string `json:"oldestLedgerCloseTime"` | |||
| ApplicationOrder int64 `json:"applicationOrder"` | |||
| Hash string `json:"txHash"` | |||
There was a problem hiding this comment.
@gouthamp-stellar Do we have any unittests. That way we can ensure all such future changes are working fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Making sure that the RPC changes listed in protocol 22: https://gist.github.com/Shaptic/6d5c76c5fe2b29e42d1d190241110281 are reflected in the wallet backend
Why
Ensuring that the latest RPC build does not break the wallet backend
Known limitations
N/A
Issue that this PR addresses
#64
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release