Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove external depedencies in tests #1148

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

bobeal
Copy link
Member

@bobeal bobeal commented Apr 28, 2024

No description provided.

bobeal added 2 commits April 28, 2024 14:44
- mainly to allow using local versions in tests
- also to make easier to use a different version of the core context
@bobeal bobeal requested a review from ranim-n April 28, 2024 12:44
@github-actions github-actions bot added the feature New feature or request label Apr 28, 2024
@bobeal bobeal linked an issue Apr 28, 2024 that may be closed by this pull request
@bobeal bobeal self-assigned this Apr 28, 2024
Copy link
Contributor

github-actions bot commented Apr 28, 2024

Test Results

 24 files   -  34   24 suites   - 34   41s ⏱️ -42s
325 tests  - 628  325 ✅  - 627  0 💤 ±0  0 ❌  - 1 
325 runs   - 667  325 ✅  - 666  0 💤 ±0  0 ❌  - 1 

Results for commit 98f90b5. ± Comparison against base commit 64999fb.

This pull request removes 772 and adds 4 tests. Note that renamed tests count towards both.
                         …, withTemporalValues=true, withAudit=false, expectation={
                      "@type": "@json",
                      …
                    "@value": "/A/B"
                    "@value": "/C/D"
                    "@value": 20
                    "…
                    {
                  "@type": "https://uri.etsi.org/ngsi-ld/DateTime",
                  "@value": "2020-03-25T08:29:17.965206Z"
…
com.egm.stellio.shared.model.LanguageFilterTests ‑ [1] nl, "languageProperty": {
    "type": "Property",
    "value": "Grote Markt",
    "lang": "nl"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [2] en, "languageProperty": {
    "type": "Property",
    "value": "Big Place",
    "lang": "@none"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [3] *, "languageProperty": {
    "type": "Property",
    "value": "Big Place",
    "lang": "@none"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [4] fr-CH,fr;q=0.9,en;q=0.8,*;q=0.5, "languageProperty": {
    "type": "Property",
    "value": "Grand Place",
    "lang": "fr"
}

♻️ This comment has been updated with latest results.

Copy link

@bobeal bobeal changed the title feat: remove external depedencies in unit test feat: remove external depedencies in tests Apr 28, 2024
@bobeal bobeal merged commit 69a9287 into develop Apr 30, 2024
8 of 9 checks passed
@bobeal bobeal deleted the feature/114-remove-external-depedencies-in-unit-test branch April 30, 2024 05:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies on external resources in unit tests
2 participants