-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge service account id to subject id #1149
Conversation
bobeal
commented
Apr 28, 2024
- if a client has service account enabled, the sub presented in the JWT is the service account id
- the client id is never used for authentication purposes and can then be dropped (a client cannot authenticate by itself if service account is not enabled)
- if a client has service account enabled, the sub presented in the JWT is the service account id - the client id is never used for authentication purposes and can then be dropped (a client cannot authenticate by itself if service account is not enabled)
Test Results 58 files ±0 58 suites ±0 1m 21s ⏱️ -1s Results for commit 02346fa. ± Comparison against base commit 69a9287. This pull request removes 170 and adds 30 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is exactly a client's service account ?
|