Feature/simplify error handling

[thomasBousselin]

No description provided.

[github-actions]

Test Results

 25 files   -  42   25 suites   - 42   34s ⏱️ -45s
355 tests  - 713  339 ✅  - 727  0 💤  - 2  16 ❌ +16 
355 runs   - 752  339 ✅  - 766  0 💤  - 2  16 ❌ +16 

For more details on these failures, see this check.

Results for commit c0287f9. ± Comparison against base commit 1bd270a.

This pull request removes 874 and adds 5 tests. Note that renamed tests count towards both.

                                    { "id":…, withTemporalValues=true, withAudit=false, expectation={
                      "@id": "https://uri…
                      "@type": "@json",
                      …
                    "@value": "/A/B"
                    "@value": "/C/D"
                    "@value": 20
                    "…
                    {
                  "@type": "https://uri.etsi.org/ngsi-ld/DateTime",
…

com.egm.stellio.shared.model.LanguageFilterTests ‑ [1] nl, "languageProperty": {
    "type": "Property",
    "value": "Grote Markt",
    "lang": "nl"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [2] en, "languageProperty": {
    "type": "Property",
    "value": "Big Place",
    "lang": "@none"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [3] *, "languageProperty": {
    "type": "Property",
    "value": "Big Place",
    "lang": "@none"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [4] fr-CH,fr;q=0.9,en;q=0.8,*;q=0.5, "languageProperty": {
    "type": "Property",
    "value": "Grand Place",
    "lang": "fr"
}
com.egm.stellio.shared.util.JsonUtilsTests ‑ it should throw an InvalidRequest exception if the JSON-LD fragment is not a valid JSON document()

♻️ This comment has been updated with latest results.

[bobeal]

here, you are also serializing the inherited Exception class, which is not the expected thing.

btw, we should also get rid of this inherited class (in FP, errors should not be exceptions). not sure of the impacts, to be checked.

[thomasBousselin]

here, you are also serializing the inherited Exception class, which is not the expected thing.

Yes fixed

btw, we should also get rid of this inherited class (in FP, errors should not be exceptions). not sure of the impacts, to be checked.

ApiException are thrown 14 times. And each time the refacto could impact multiple layer of functions.

[bobeal]

it should be the ultimate hierarchy for representing errors (https://old.arrow-kt.io/docs/patterns/error_handling/)

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
43.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud