Implement conformance test binary #661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
push-d961a3d6e69d4179ba27ba7cafc632e6
branch
from
3f946df
to
12a57ad
Compare
Ralith
force-pushed
the
push-d961a3d6e69d4179ba27ba7cafc632e6
branch
from
12a57ad
to
be1cb07
Compare
|
I think this is working now. It's found a bunch of failures when ran against the test suite from 3.21. Looks like a lot of unexpected successful parses (particularly around EoF handling), but also some panics and many cases of data failing to pass through. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the conformance test protocol defined at https://github.com/protocolbuffers/protobuf/tree/main/conformance.