Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply RUSTC_WRAPPER when querying rustc version #737

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

RalfJung
Copy link
Contributor

@RalfJung RalfJung commented Sep 1, 2024

Fixes #735

The alternative would have been to depend on https://crates.io/crates/rustc_version, but that would have been a larger change.

@RalfJung
Copy link
Contributor Author

RalfJung commented Oct 2, 2024

@stepancheg did you have any chance to look at this? :)
This crate shows up in the rustc compiler workspace, which makes this a blocking issue for rust-lang/rust#127682.

@stepancheg stepancheg merged commit 37e0613 into stepancheg:master Oct 15, 2024
10 checks passed
@stepancheg
Copy link
Owner

I don't fully understand it, but someone else asked me to merge it, so this is it.

@stepancheg
Copy link
Owner

Actually, I removed nightly detection from build.rs of protobuf crate, because it is not needed for the crate itself, only for benches, and I moved benches outside.

@RalfJung
Copy link
Contributor Author

That's even better, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build script does not honor RUSTC_WRAPPER
2 participants