DP01 - chore(refactoring): Se evita magic strings

abstract-factory/src/main/java/com/stephanoapiolaza/dessignpattern/abstractfactory/AbstractFactory.java

@@ -26,6 +26,7 @@
 import com.stephanoapiolaza.dessignpattern.abstractfactory.color.Color;
 import com.stephanoapiolaza.dessignpattern.abstractfactory.color.ColorFactory;
 import com.stephanoapiolaza.dessignpattern.abstractfactory.enumeration.ColorTipoEnum;
+import com.stephanoapiolaza.dessignpattern.abstractfactory.enumeration.FactoryTipoEnum;
 import com.stephanoapiolaza.dessignpattern.abstractfactory.enumeration.FiguraTipoEnum;
 import com.stephanoapiolaza.dessignpattern.abstractfactory.shape.Figura;
 import com.stephanoapiolaza.dessignpattern.abstractfactory.shape.FiguraFactory;
@@ -63,10 +64,10 @@ public abstract class AbstractFactory {
 	 * @param choice factoria a crear
 	 * @return factoria solicitada
 	 */
-	public static AbstractFactory getFactory(String choice) {
-		if ( choice.equals("SHAPE")) {
+	public static AbstractFactory getFactory(FactoryTipoEnum choice) {
+		if ( choice.equals(FactoryTipoEnum.SHAPE)) {
 			return new FiguraFactory();
-		} else if ( choice.equals("COLOR")) {
+		} else if ( choice.equals(FactoryTipoEnum.COLOR)) {
 			return new ColorFactory();
 		}
 		return null;

abstract-factory/src/main/java/com/stephanoapiolaza/dessignpattern/abstractfactory/enumeration/FactoryTipoEnum.java

@@ -0,0 +1,41 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) [2018] [Stephano Apiolaza]
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+package com.stephanoapiolaza.dessignpattern.abstractfactory.enumeration;
+
+/**
+ * Clase que representa todos los posibles tipos 
+ * de factories a utilizar
+ * 
+ * @see {@link https://www.tutorialspoint.com/design_pattern/abstract_factory_pattern.htm}
+ * @category Patrones Creacionales - Objeto
+ * @version 1.0 - 02-05-18
+ * @author Stephano.Apiolaza - stephanoapiolaza@gmail.com
+ *
+ */
+public enum FactoryTipoEnum {
+
+    SHAPE,
+    COLOR;
+
+}