Fixes for Safari

stephband · May 19, 2022 · 0360a13 · 0360a13
1 parent 505c404
commit 0360a13
Show file tree

Hide file tree

Showing 11 changed files with 26 additions and 29 deletions.
diff --git a/build/slide-show-figure.js b/build/slide-show-figure.js
diff --git a/build/slide-show-ol.js b/build/slide-show-ol.js
diff --git a/build/slide-show-shadow.css b/build/slide-show-shadow.css
diff --git a/build/slide-show-ul.js b/build/slide-show-ul.js
diff --git a/build/slide-show.css b/build/slide-show.css
diff --git a/build/slide-show.js b/build/slide-show.js
diff --git a/docs/docs.css b/docs/docs.css
diff --git a/docs/docs.js b/docs/docs.js
diff --git a/modules/active.js b/modules/active.js
@@ -95,7 +95,6 @@ function getAligned(scroller, elements) {
 
         // If position has crossed the detection going left, we're in the money
         if (x <= detection) {
-            console.log(x, detection, slide);
             break;
         }
     }
@@ -120,7 +119,7 @@ export function updateActive(data) {
     const { scroller, children, elements } = data;
     const current = getAligned(scroller, elements);
     let active;
-console.log('CURRENT', current);
+
     // If current is a loop ghost jump to the actual slide it references
     if (!current) { return; }
     if (isGhost(current)) {

diff --git a/modules/lifecycle.js b/modules/lifecycle.js
@@ -56,7 +56,7 @@ Emitted by a slide when it is brought into scroll-snap alignment.
 export default {
     construct: function(shadow) {
         // Shadow DOM
-        const slides   = create('slot', { part: 'slides', style: 'display: grid;' });
+        const slides   = create('slot', { part: 'slides' });
         const scroller = create('div',  { class: 'scroller', children: [slides] });
         const controls = create('nav',  { part: 'controls', children: [
             create('slot', { name: 'controls' })
@@ -104,7 +104,6 @@ export default {
             ))
             .filter((child) => (data.active !== child && trigger('slide-active', child)))
             .map((child) => data.active = child)
-            .log('ACTIVE')
             .broadcast({ memory: true, hot: true });
 
         const clicks = events('click', shadow)

diff --git a/test/2-slide-show.html b/test/2-slide-show.html
@@ -65,7 +65,7 @@
 </head>
 
 <body>
-    <!--pre>&lt;slide-show loop autoplay controls="navigation pagination fullscreen"&gt; - one child</pre>
+    <pre>&lt;slide-show loop autoplay controls="navigation pagination fullscreen"&gt; - one child</pre>
 
     <slide-show loop autoplay controls="navigation pagination fullscreen">
         <img src="../docs/images/bourg.jpg" draggable="false" />
@@ -81,7 +81,7 @@
         <a href="/" draggable="false" id="summit"><img src="../docs/images/summit.jpg" draggable="false" /></a>
     </slide-show>
 
-    <pre>&lt;slide-show loop autoplay controls="navigation pagination fullscreen"&gt; - one child</pre-->
+    <pre>&lt;slide-show loop autoplay controls="navigation pagination fullscreen"&gt; - one child</pre>
 
     <slide-show class="main-slide-show" loop autoplay controls="navigation pagination fullscreen" active="#mauverin">
         <a href="/" draggable="false"><img src="../docs/images/donkeys.jpg" draggable="false" /></a>
@@ -91,7 +91,7 @@
         <a href="/" draggable="false"><img src="../docs/images/summit.jpg" draggable="false" /></a>
     </slide-show>
 
-    <!--slide-show class="tab-slide-show">
+    <slide-show class="tab-slide-show">
         <a class="tab-button button" href="#1" draggable="false">Explore</a>
         <a class="tab-button button active" href="#2" draggable="false">Buy</a>
         <a class="tab-button button" href="#3" draggable="false">Free trial</a>
@@ -141,7 +141,7 @@
         <img src="../docs/images/bourg.jpg" draggable="false" />
         <img src="../docs/images/tractor.jpg" draggable="false" />
         <img src="../docs/images/bourg.jpg" draggable="false" />
-    </slide-show-->
+    </slide-show>
 
     <script type="module">
         import '../slide-show.js';
@@ -156,7 +156,7 @@
 
 
         // -----
-/*
+
         test(0, 'create <slide-show> with no children', (done) => {
             const show = document.createElement('slide-show');
             done(show);
@@ -305,7 +305,6 @@
                 )
             );
         }, true);
-*/
     </script>
 </body>
 </html>