removing cp36 and cp37 from manylinux2014 build due to setuptools_scm…

… auto-versioning incompatibility
stephen-dixon · Apr 14, 2024 · 671af43 · 671af43
1 parent 97510ca
commit 671af43
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/.github/workflows/build_wheels.yml b/.github/workflows/build_wheels.yml
@@ -60,7 +60,7 @@ jobs:
           CIBW_MANYLINUX_AARCH64_IMAGE: manylinux2014
           CIBW_ARCHS: ${{matrix.build-platform[1]}}
           CIBW_BUILD: cp*-manylinux*
-          CIBW_SKIP: "*-musllinux*"
+          CIBW_SKIP: cp36* cp37* *-musllinux*
           CIBW_BEFORE_ALL: >
             yum update -y &&
             yum install -y wget openssl-devel libxml2-devel libtirpc-devel  &&

diff --git a/source/wrappers/python/pyproject.toml b/source/wrappers/python/pyproject.toml
@@ -1,5 +1,5 @@
 [build-system]
-requires = ["setuptools>=42", "setuptools_scm", "numpy>=1.7", "Cython>=0.29", "six"]
+requires = ["setuptools>=42", "setuptools_scm>=8", "numpy>=1.7", "Cython>=0.29", "six"]
 build-backend = "setuptools.build_meta"
 
 

diff --git a/source/wrappers/python/setup.py.in b/source/wrappers/python/setup.py.in
@@ -78,16 +78,10 @@ ext = Extension(
     define_macros=extra_macros,
 )
 
-
-# redefine here instead of using "no-local-version" in case we can get setuptools_scm to work for older python versions (3.6 and 3.7)
-def local_scheme(version):
-    return ""
-
-
 # version='@PROJECT_VERSION@',
 setup(
     name='ukaea_pyuda_test',
-    use_scm_version={'version_scheme': 'post-release', 'local_scheme': local_scheme},
+    use_scm_version={'version_scheme': 'post-release', 'local_scheme': 'no-local-version'},
     description='Unified Data Access (UDA)',
     author='Jonathan Hollocombe',
     author_email='jonathan.hollocombe@ukaea.uk',