-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VisionOS support #1237
Add VisionOS support #1237
Conversation
It looks like this test failure is unrelated to this PR, as it was also failing in this other PR. |
@nathanfallet, any chance we could get some eyes on this? We've got users of our SDK asking for VisionOS support, and we are waiting on support in this library to make that work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just waiting for checks to run
Awesome thank you! Looks like the just that one broken test that is failing still. |
Yes I need to check why; I don't think it's related to visionOS addition, but I don't want to merge if it's failing 😅 |
@nathanfallet Where does this stand? |
05af27b
to
5bfaddf
Compare
ea56e25
to
fec58b9
Compare
Last thing to fix:
I had the warning for @jberkel any idea on this? |
It's probably CocoaPods/CocoaPods#11839. If you manage to work around it, I'll be happy to know your solution :-) |
@nathanfallet - where are we on getting this resolved and merged? |
@calvincestari I'm trying to find a solution with cocoapods that currently breaks the project. When that will be fixed, we'll be able to merge it. |
@nathanfallet Any luck or insight on the cocoapods breaking the VisionOS support? |
Thanks for getting this merged @nathanfallet, much appreciated! |
@nathanfallet, another question for this: will the podspec be updated to declare support for visionOS too? When I try push our updated podspec I get an error about incompatibility with SQLite.swift and visionOS. I believe it requires another deployment target.
|
@calvincestari I'll have a look at that, it might have been missing in the PR |
This PR adds support or VisionOS by:
Package.swift
fileWhen running the tests on visionOS, there is a single failing test. I'm not familiar enough with the library to know what could be causing that failure. If someone is able to point me in the right direction, I'd be happy to get the test passing so this can be merged in.