Skip to content

Move webapp folder in the default Spring Boot location#1745

Closed
juherr wants to merge 3 commits intosteve-community:masterfrom
juherr:spring-boot-webapp
Closed

Move webapp folder in the default Spring Boot location#1745
juherr wants to merge 3 commits intosteve-community:masterfrom
juherr:spring-boot-webapp

Conversation

@juherr
Copy link
Copy Markdown
Contributor

@juherr juherr commented Apr 1, 2025

Related to #1733

@goekay
Copy link
Copy Markdown
Member

goekay commented Apr 2, 2025

could you please elaborate the changes?

@juherr
Copy link
Copy Markdown
Contributor Author

juherr commented Apr 2, 2025

It is just moving the folder into the common folder used by spring boot for jsp.
I didn't see any side effect of the changes.

@goekay
Copy link
Copy Markdown
Member

goekay commented Apr 7, 2025

It is just moving the folder into the common folder used by spring boot for jsp.
I didn't see any side effect of the changes.

i just question this claim about common/default folder by spring boot, because i did not encounter such a thing in my experience.

@juherr
Copy link
Copy Markdown
Contributor Author

juherr commented Apr 7, 2025

As I understand it:

@juherr
Copy link
Copy Markdown
Contributor Author

juherr commented Jul 27, 2025

Closed in favor of migrating to Thymeleaf, which is a more appropriate next step.
See: juherr#5

@juherr juherr closed this Jul 27, 2025
@juherr juherr deleted the spring-boot-webapp branch July 27, 2025 21:19
@goekay
Copy link
Copy Markdown
Member

goekay commented Sep 18, 2025

hey @juherr could you please revert the deletion and reopen this PR?

@juherr juherr restored the spring-boot-webapp branch September 18, 2025 18:46
@juherr juherr reopened this Sep 18, 2025
@juherr
Copy link
Copy Markdown
Contributor Author

juherr commented Sep 18, 2025

@goekay done. Feel free to update it.

files were taken as-is from downstream. the feature branch does not include all the other changes from downstream.
this branch probably will not compile anymore.
goekay added a commit that referenced this pull request Sep 19, 2025
spiritual replacement of #1745
because the feature branch was old and fixing conflicts was not fun.
@goekay
Copy link
Copy Markdown
Member

goekay commented Sep 19, 2025

fixing conflicts was not fun. i abandoned it. instead, i applied the same changes on top of current HEAD in #1821

as always, thanks for the help @juherr and sorry for the unnecessary effort/trouble i caused.

@goekay goekay closed this Sep 19, 2025
@juherr juherr deleted the spring-boot-webapp branch September 19, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants