Move webapp folder in the default Spring Boot location#1745
Closed
juherr wants to merge 3 commits intosteve-community:masterfrom
Closed
Move webapp folder in the default Spring Boot location#1745juherr wants to merge 3 commits intosteve-community:masterfrom
juherr wants to merge 3 commits intosteve-community:masterfrom
Conversation
Member
|
could you please elaborate the changes? |
Contributor
Author
|
It is just moving the folder into the common folder used by spring boot for jsp. |
Member
i just question this claim about common/default folder by spring boot, because i did not encounter such a thing in my experience. |
Contributor
Author
|
As I understand it:
|
Contributor
Author
|
Closed in favor of migrating to Thymeleaf, which is a more appropriate next step. |
Member
|
hey @juherr could you please revert the deletion and reopen this PR? |
Contributor
Author
|
@goekay done. Feel free to update it. |
files were taken as-is from downstream. the feature branch does not include all the other changes from downstream. this branch probably will not compile anymore.
This reverts commit 2482f31.
goekay
added a commit
that referenced
this pull request
Sep 19, 2025
spiritual replacement of #1745 because the feature branch was old and fixing conflicts was not fun.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1733