Precommit #16
Merged
Precommit #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the pre-commit framework to check cmake, clang-format, spellcheck, git, and shell scripts.
Also the default install dir.
Add -C option
Spelling, formating, caps, etc.
add the commit that was just lint fixes.
Add gcovr pip install and cmake targets and configurations for running coverage and collecting and processing the results.
The lint target excludes, e.g. clang-format-fix and clang-tidy.
Make lint, lint-manual, and coverage as not producing a file. Remove targets.mk as a source for help messages in help target.
Run a script to install and run pre-commit in a python3 virtual environment and tweak shellcheckrc to allow the venv activation source as part of the script. shellcheck...............................................................Passed
Format errors and such,
Suggests that some refactoring is in order, but since this is also testing shellcheck itself, it's an OK exercise. Since there isn't a venv created in the CI action that runs shellcheck, it can't read the script to check for issues.
`nd`` was flagged as a possible typo, change it as it's not really significant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.