Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP2Location.io Driver #150

Merged
merged 10 commits into from
Nov 23, 2023
Merged

Add IP2Location.io Driver #150

merged 10 commits into from
Nov 23, 2023

Conversation

ip2location
Copy link
Contributor

Related to #147 .

@ip2location
Copy link
Contributor Author

Hi @stevebauman ,

May I check what is the progress now?

@stevebauman
Copy link
Owner

Sorry for the late review on this @ip2location! Looks good to me, thanks for your contribution!

The test added in this PR is failing, can you fix it? Once fixed, I'll merge and deploy a new version 👍

@ip2location
Copy link
Contributor Author

Sorry for the late review on this @ip2location! Looks good to me, thanks for your contribution!

The test added in this PR is failing, can you fix it? Once fixed, I'll merge and deploy a new version 👍

Hi @stevebauman,

I have checked the error message, but looks like it is failing on Maxmind's driver, I'm not sure what I can do from my side.

@stevebauman
Copy link
Owner

Screenshot 2023-11-21 at 7 32 09 PM

@ip2location
Copy link
Contributor Author

Screenshot 2023-11-21 at 7 32 09 PM

Hi @stevebauman ,

I didn't noticed this on yesterday. I have pushed new fix for the failing test and the test case is passed on my side.

@stevebauman stevebauman merged commit fc4dc2e into stevebauman:master Nov 23, 2023
1 of 7 checks passed
@stevebauman
Copy link
Owner

No worries, thanks for fixing it! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants