-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IP2Location.io Driver #150
Conversation
Hi @stevebauman , May I check what is the progress now? |
Sorry for the late review on this @ip2location! Looks good to me, thanks for your contribution! The test added in this PR is failing, can you fix it? Once fixed, I'll merge and deploy a new version 👍 |
Hi @stevebauman, I have checked the error message, but looks like it is failing on Maxmind's driver, I'm not sure what I can do from my side. |
Hi @stevebauman , I didn't noticed this on yesterday. I have pushed new fix for the failing test and the test case is passed on my side. |
No worries, thanks for fixing it! 🙏 |
Related to #147 .