Merge pull request #7 from GVSO/master

Use space character as scope separator
stevenmaguire · May 3, 2018 · 05b2da5 · 05b2da5
2 parents ed90481 + 6c5037f
commit 05b2da5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Provider/Bitbucket.php b/src/Provider/Bitbucket.php
@@ -57,6 +57,17 @@ protected function getDefaultScopes()
         return [];
     }
 
+    /**
+     * Returns the string that should be used to separate scopes when building
+     * the URL for requesting an access token.
+     *
+     * @return string Scope separator, defaults to ' '
+     */
+    protected function getScopeSeparator()
+    {
+        return ' ';
+    }
+
     /**
      * Check a provider response for errors.
      *

diff --git a/test/src/Provider/BitbucketTest.php b/test/src/Provider/BitbucketTest.php
@@ -42,7 +42,7 @@ public function testAuthorizationUrl()
 
     public function testScopes()
     {
-        $scopeSeparator = ',';
+        $scopeSeparator = ' ';
         $options = ['scope' => [uniqid(), uniqid()]];
         $query = ['scope' => implode($scopeSeparator, $options['scope'])];
         $url = $this->provider->getAuthorizationUrl($options);