Attendence Endpoint #6
Conversation
…eck Postgresql in UserService and UserServiceImpl
…ce database controller added handlers. please check implementation and return type
…pository to reflect actual database name
…dded object to model.users package should fix UserServiceImpl.java
…ice and UserServiceImpl
|
CI is only failing on one testcase. likely a database issue. code is NOT ready for review yet |
|
@miguel-merlin Can I get feedback on the code I have written thus far. just to know if I am on the right track. Thank You |
There was a problem hiding this comment.
@ezhang04 Looks good! Make sure to change AttendanceRecordRepository.java to repository/attendance/AttendanceRecordRepository.java. Keep it up!
| @@ -0,0 +1,49 @@ | |||
| package com.sitblueprint.admin.controller; | |||
There was a problem hiding this comment.
Eric, for future reference we try to stick to conventional commit messages: You can find them here
| @@ -20,4 +21,14 @@ public interface UserService { | |||
| void disableUserById(Long userId); | |||
|
|
|||
| void resetPassword(Long userId, String password); | |||
|
|
|||
| Attendance getAttendanceById(Long attendanceId); | |||
There was a problem hiding this comment.
nit: Attendance getAttendanceById(Long userId). I image this endpoint is to get the attendance given a userId
| } | ||
|
|
||
| @Override | ||
| public Attendance createAttendance(Attendance attendance){ |
There was a problem hiding this comment.
For this endpoint, you have to check if an Attendance record is already related to a user. If that's the case, return an error since only one attendance record can be related to a user.
|
@ezhang04 Please do |
Added Attendance Object. Created and Initialized AttendanceRecordRepository database. Created AttendanceController. Added handlers: createAttendance, getAttendanceById, getAttendances, updateAttendance, deleteAttendance.
Relates (unshare if this closes) to #5