chore(docs): updates desc of methods #340
Conversation
BREAKING CHANGE: adds angular 19 support
# Conflicts: # package-lock.json # package.json # projects/ngx-cookie-service-ssr/package.json # projects/ngx-cookie-service/package.json
|
Hello 👋 @pavankjadda |
|
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
projects/ngx-cookie-service/src/lib/cookie.service.ts:272
- [nitpick] The phrase 'If not path is not specified' is awkward; revising it to 'If no path is specified, all cookies at '/' path will be deleted.' would improve clarity.
* Delete all cookies at given path and domain. If not path is not specified, all cookies at '/' path will be deleted.
| @@ -233,7 +233,7 @@ export class SsrCookieService { | |||
| } | |||
|
|
|||
| /** | |||
| * Delete cookie by name | |||
| * Delete cookie by name at given path and domain. If not path is not specified, cookie at '/' path will be deleted. | |||
There was a problem hiding this comment.
[nitpick] The phrasing 'If not path is not specified' is grammatically incorrect. Consider changing it to 'If no path is specified, cookie at '/' path will be deleted.'
| * Delete cookie by name at given path and domain. If not path is not specified, cookie at '/' path will be deleted. | |
| * Delete cookie by name at given path and domain. If no path is specified, cookie at '/' path will be deleted. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| @@ -253,7 +253,7 @@ export class SsrCookieService { | |||
| } | |||
|
|
|||
| /** | |||
| * Delete all cookies | |||
| * Delete all cookies at given path and domain. If not path is not specified, all cookies at '/' path will be deleted. | |||
There was a problem hiding this comment.
[nitpick] The comment contains the phrase 'If not path is not specified' which is unclear; consider revising it to 'If no path is specified, all cookies at '/' path will be deleted.'
| * Delete all cookies at given path and domain. If not path is not specified, all cookies at '/' path will be deleted. | |
| * Delete all cookies at given path and domain. If no path is specified, all cookies at '/' path will be deleted. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| @@ -252,7 +249,7 @@ export class CookieService { | |||
| } | |||
|
|
|||
| /** | |||
| * Delete cookie by name | |||
| * Delete cookie by name at given path and domain. If not path is not specified, cookie at '/' path will be deleted. | |||
There was a problem hiding this comment.
[nitpick] The doc comment uses 'If not path is not specified' which is grammatically incorrect. Please change it to 'If no path is specified, cookie at '/' path will be deleted.'
| * Delete cookie by name at given path and domain. If not path is not specified, cookie at '/' path will be deleted. | |
| * Delete cookie by name at given path and domain. If no path is specified, cookie at '/' path will be deleted. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
closes #339