Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): correct type annotation for platformId in cookie service #341

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

pavankjadda
Copy link
Collaborator

No description provided.

BREAKING CHANGE: adds angular 19 support
# Conflicts:
#	package-lock.json
#	package.json
#	projects/ngx-cookie-service-ssr/package.json
#	projects/ngx-cookie-service/package.json
# Conflicts:
#	projects/ngx-cookie-service/src/lib/cookie.service.ts
@pavankjadda pavankjadda requested a review from Copilot February 20, 2025 21:50
@pavankjadda pavankjadda self-assigned this Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link

Hello 👋 @pavankjadda
Thank you for raising your pull request. Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

@pavankjadda pavankjadda merged commit ac9c5e3 into master Feb 20, 2025
3 checks passed
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant