MAINT: Refactor sops secrets to enable App-specific secrets #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split sops secrets into 2 parts - infra and apps the infra secrets should only be used by the management cluster new apps folder for storing cluster-specific secrets pertaining to apps running on the cluster. This allows us to use different keys for the child clusters and the secrets will not be accessible by the management cluster - allows separation of roles.
add a script that will update all sops secrets for a given cluster and environment TODO: update this script to automatically add a new key in to .sops.yaml if given as a parameter
add config to enable using secrets on all clusters
not every chart needs cluster-specific values - use dummy secret to make this parameter optional like for secretsFile
update docs to explain how to add app-related secrets
change secrets structure to be environment / clustername / secret-type more intuitive and saves extra folders needing to be created
test the new secrets methodology using feature-branch update-secrets
anish-mudaraddi
force-pushed
the
update-secrets
branch
from
b7e8619 to
37e937a
Compare
|
dev management and worker clusters are using this feature branch with no issues - I believe this is ready for deployment. I want to change dev/staging/prod all at once with this PR to avoid the headache of promoting and having to remember 2 different procedures for handling secrets |
RJaliliSTFC
approved these changes
Nov 28, 2024
khalford
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now using Sops secrets for applications like manila/galaxy - this requires separate keys on every cluster
The keys that go on each cluster are supposed to be temporary - ideally none should have access to these once the cluster's been created.
This PR splits secrets into infra and apps
This is a major change - this should become a feature branch that we point dev to before merging into main - hence I've left it in draft