Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v5 #242

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Update to v5 #242

merged 2 commits into from
Dec 12, 2024

Conversation

khalford
Copy link
Member

@khalford khalford commented Dec 12, 2024

Description:

Update to version 5 of the chatops image. This gives us access to the /find-host comand. For this we need to add the node IP to the environment variables and add the pull requests channel to the config.


Submitter:

Have you:

  • Labelled this PR, e.g. bug, deployment, enhancement ...etc.
  • A deployment can be reviewed, and merged, by a single reviewer.
  • It can only be used to deploy, change, or remove clusters based on existing patterns for staging.
  • Anything involving prod, or production facing services must use the normal 2 person review.
  • All other PR types require the usual PR process (e.g. 2 person).

Reviewer

Have you:

  • Verified this PR uses the correct label(s) based on the rules above?
  • Checked if this could affect production (e.g. a global value that's changed without an override)?
  • Tested setting this up, if it's not a deployment, to verify it can be redeployed with any documentation if appropriate?

Making the node IP available to the pod environment for the application to read.
Updating to version 5 so we have access to the find host command which will be useful as we now have more than one  pod.
@khalford khalford added the enhancement New feature or request label Dec 12, 2024
@khalford khalford self-assigned this Dec 12, 2024
Copy link
Collaborator

@anish-mudaraddi anish-mudaraddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have some questions

@khalford khalford merged commit 5b7c7de into main Dec 12, 2024
4 checks passed
@khalford khalford deleted the update_to_v5 branch December 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants