Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy chatops app on dev-cloud-chatops cluster #247

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Deploy chatops app on dev-cloud-chatops cluster #247

merged 6 commits into from
Dec 16, 2024

Conversation

khalford
Copy link
Member

@khalford khalford commented Dec 13, 2024 •
edited
Loading

Description:

Adds apps to dev-cloud-chatops cluster and remove them from dev-worker.

Submitter:

Have you:

  • Labelled this PR, e.g. bug, deployment, enhancement ...etc.
  • A deployment can be reviewed, and merged, by a single reviewer.
  • It can only be used to deploy, change, or remove clusters based on existing patterns for staging.
  • Anything involving prod, or production facing services must use the normal 2 person review.
  • All other PR types require the usual PR process (e.g. 2 person).

Reviewer

Have you:

  • Verified this PR uses the correct label(s) based on the rules above?
  • Checked if this could affect production (e.g. a global value that's changed without an override)?
  • Tested setting this up, if it's not a deployment, to verify it can be redeployed with any documentation if appropriate?

@khalford khalford self-assigned this Dec 13, 2024
anish-mudaraddi
anish-mudaraddi requested changes Dec 13, 2024
View reviewed changes
clusters/dev/cloud-chatops/apps.yaml

- name: chatops
chartName: chatops
namespace: chatops
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't have cluster-specific values? - its not a problem just curious

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so? I didn't have any in the worker cluster so shouldn't need any here

@anish-mudaraddi anish-mudaraddi merged commit 2263f18 into main Dec 16, 2024
2 checks passed
@anish-mudaraddi anish-mudaraddi deleted the deploy_chatops_app branch December 16, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anish-mudaraddi anish-mudaraddi anish-mudaraddi approved these changes

Assignees

@khalford khalford

Labels
deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalford @anish-mudaraddi