Add CI test against development versions #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinelena
reviewed
Feb 24, 2025
alinelena
reviewed
Feb 24, 2025
There was a problem hiding this comment.
Looks great generally!
A couple of suggestions to think about:
- I'm open to arguments either way, but I think we may want to only run this on pushes to main, while this will run on every push to PRs etc., which is probably more than is needed
- Probably on me for describing this poorly, but I think
uv pip installprobably makes sense overuv add.uv addwill force compatibility with other dependencies, which may fail, but that's not really a problem for this sort of test
|
As a note: we were unsure if https://github.com/k-harris27/actions-test/actions/runs/13501767954 |
Co-authored-by: ElliottKasoar <45317199+ElliottKasoar@users.noreply.github.com>
ElliottKasoar
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should test against up-to-date development versions of ASE and MACE during CI.
It shouldn't fail the CI if the tests fail, so that we can have a warning about upcoming breaking changes.