Skip to content

Commit

Permalink
fix reviewcontroller tests
Browse files Browse the repository at this point in the history
  • Loading branch information
joschli committed Sep 20, 2018
1 parent e9cf9cf commit 3559d19
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions mubench.reviewsite/tests/ReviewControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function test_determine_next_misuse_current_and_next_are_reviewed()
$this->createConclusiveReviewState($misuse2);

// current misuse = 1, reviewer = 1
list($previous_misuse, $next_misuse, $next_reviewable_misuse, $misuse) = $this->reviewController->determineNavigationTargets($runs, Experiment::find(2), '-p-', '-v-', $misuse1->misuse_muid, $this->reviewer1, 30);
list($previous_misuse, $next_misuse, $next_reviewable_misuse, $misuse) = $this->reviewControllerHelper->reviewController->determineNavigationTargets($runs, Experiment::find(2), '-p-', '-v-', $misuse1->misuse_muid, $this->reviewer1, 30);

self::assertEquals($misuse3->misuse_muid, $previous_misuse->misuse_muid);
self::assertEquals($misuse2->misuse_muid, $next_misuse->misuse_muid);
Expand All @@ -99,7 +99,7 @@ function test_determine_next_misuse_current_is_only_reviewable()
$this->createConclusiveReviewState($misuse2);

// current misuse = 3, reviewer = 1
list($previous_misuse, $next_misuse, $next_reviewable_misuse, $misuse) = $this->reviewController->determineNavigationTargets($runs, Experiment::find(2), '-p-', '-v-', $misuse3->misuse_muid, $this->reviewer1, 30);
list($previous_misuse, $next_misuse, $next_reviewable_misuse, $misuse) = $this->reviewControllerHelper->reviewController->determineNavigationTargets($runs, Experiment::find(2), '-p-', '-v-', $misuse3->misuse_muid, $this->reviewer1, 30);

self::assertEquals($misuse2->misuse_muid, $previous_misuse->misuse_muid);
self::assertEquals($misuse1->misuse_muid, $next_misuse->misuse_muid);
Expand All @@ -118,7 +118,7 @@ function test_determine_next_misuse_not_fully_reviewed()
$this->reviewControllerHelper->createReview($misuse3, $this->reviewer2, "Yes");

// current misuse = 1, reviewer = 1
list($previous_misuse, $next_misuse, $next_reviewable_misuse, $misuse) = $this->reviewController->determineNavigationTargets($runs, Experiment::find(2), '-p-', '-v-', $misuse1->misuse_muid, $this->reviewer1, 30);
list($previous_misuse, $next_misuse, $next_reviewable_misuse, $misuse) = $this->reviewControllerHelper->reviewController->determineNavigationTargets($runs, Experiment::find(2), '-p-', '-v-', $misuse1->misuse_muid, $this->reviewer1, 30);

self::assertEquals($misuse3->misuse_muid, $previous_misuse->misuse_muid);
self::assertEquals($misuse2->misuse_muid, $next_misuse->misuse_muid);
Expand All @@ -136,7 +136,7 @@ function test_determine_nav_multiple_runs()
$this->createConclusiveReviewState($misuse1);

// current misuse = 2, reviewer = 1
list($previous_misuse, $next_misuse, $next_reviewable_misuse, $misuse) = $this->reviewController->determineNavigationTargets($runs, Experiment::find(2), '-p1-', '-v-', $misuse2->misuse_muid, $this->reviewer1, 30);
list($previous_misuse, $next_misuse, $next_reviewable_misuse, $misuse) = $this->reviewControllerHelper->reviewController->determineNavigationTargets($runs, Experiment::find(2), '-p1-', '-v-', $misuse2->misuse_muid, $this->reviewer1, 30);

self::assertEquals($misuse1->misuse_muid, $previous_misuse->misuse_muid);
self::assertEquals($misuse1->misuse_muid, $next_misuse->misuse_muid);
Expand Down

0 comments on commit 3559d19

Please sign in to comment.