Testing CPP library update #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Added conditional execution for environment setup and CMake configuration steps based on the presence of matrix.cc.
Changed the stlab/cpp-library commit hash in CPMAddPackage to 69e1aff67499f3fb227f279a5472e46d312b3a84 for improved compatibility or bug fixes.
Bumped the stlab/cpp-library dependency from commit 69e1aff to 39419e2 to incorporate recent changes and improvements from the upstream repository.
Removes the install-test job from the CI workflow and updates the stlab/cpp-library dependency to a new commit hash in CMakeLists.txt. Also fixes quoting in INSTALL_PREFIX assignment for cross-platform compatibility.
Renamed the CMake project from 'stlab-enum-ops' to 'enum-ops' and updated the referenced dependency hash for 'cpp-library'. Also updated the CI workflow to use the new project name in find_package and status messages.
The CI workflow now sets CC and CXX environment variables conditionally based on the matrix, and splits the build/install steps accordingly. The cpp-library dependency is updated to commit 4f09b3b7f0abcc4ef1b39060ce03784920ce32e5 in CMakeLists.txt.
| find_package(stlab-enum-ops REQUIRED) | ||
| message(STATUS "Successfully found stlab-enum-ops") |
There was a problem hiding this comment.
Bug: Package name mismatch between CMakeLists and workflow test
The workflow test tries to find a package named stlab-enum-ops, but the project name in CMakeLists.txt was changed to enum-ops. This mismatch will cause the cmake command in the "Test find_package" step to fail with a package not found error, since the generated CMake config files will use the new project name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Expands CI with named OS/compiler matrix and install/find_package verification, renames project, updates cpp-library reference, and adds an install CMake preset.
Ubuntu GCC,Ubuntu Clang,macOS,Windows; setfail-fast: false.CC/CXXper matrix entry.find_package(stlab-enum-ops)verification usingCMAKE_PREFIX_PATH.stlab-enum-opstoenum-opsinCMakeLists.txt.4f09b3b...).CPM_SOURCE_CACHEsetup when not predefined.installconfigure/build presets inCMakePresets.jsonfor local install testing.Written by Cursor Bugbot for commit d212a13. This will update automatically on new commits. Configure here.