Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes and improvements #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

dpavle
Copy link

@dpavle dpavle commented Dec 5, 2023

Description

  1. Removed python-pexpect package from the apt install task in packages.yml
  2. Become unprivileged user with sudo in configure command instead of within Ansible

Motivation and Context

  1. python-pexpect doesn't exist in Ubuntu 22.04 (under that name), and it's handled by pip a step below anyway, so there's no reason to install it here.
  2. Ansible doesn't recommend becoming an unprivileged user, and since we're using the command module, it is safer to just use sudo -u to do this.

How Has This Been Tested?

Installed, reconfigured and uninstalled vsts-agent on a Ubuntu 22.04 virtual machine using the role

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant