fix(nodes, accessors): fix validations with $ref nodes#35
Open
CptKirk wants to merge 1 commit intostoplightio:masterfrom
Open
fix(nodes, accessors): fix validations with $ref nodes#35CptKirk wants to merge 1 commit intostoplightio:masterfrom
CptKirk wants to merge 1 commit intostoplightio:masterfrom
Conversation
Allow usage of readOnly and WriteOnly tags on $ref nodes fix stoplightio#34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow usage of readOnly and WriteOnly tags on $ref nodes
fix #34
Motivation and Context
See #34
Description
When setting node validations, the original fragment is also passed to the function to be able to parse
readOnlyandwriteOnlytags. If no original fragment is provided, the function works as before, to not introduce breaking changes.How Has This Been Tested?
Unit tests were added to assure correct validation.
Screenshot(s)/recordings(s)
See #34
Types of changes
Checklist