Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: swap @stoplight/json-schema-ref-parser to @apidevtools/json-schema-ref-parser #2507

Conversation

liamc-altruistiq
Copy link

Addresses #2278

Summary

This PR aims to swap the library marked as deprecated by npm: @stoplight/json-schema-ref-parser to @apidevtools/json-schema-ref-parser which looks to be a drop-in replacement that is recommended by npm ci.

This was initially noticed as a warning in a project that uses @stoplight/prism, and the project has strict guidelines to upgrade/replace deprecated/insecure packages as soon as possible.

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

@liamc-altruistiq liamc-altruistiq requested a review from a team as a code owner April 3, 2024 10:28
@liamc-altruistiq liamc-altruistiq requested review from kaylachun and removed request for a team April 3, 2024 10:28
@liamc-altruistiq
Copy link
Author

I will address the build failures

@liamc-altruistiq
Copy link
Author

Hopefully to be fixed as part of APIDevTools/json-schema-ref-parser#341

@liamc-altruistiq
Copy link
Author

@kaylachun addressed the build failures and ready for review! Sorry for the delay

@brendarearden
Copy link
Contributor

@stoplight/json-schema-ref-parser is not marked as deprecated. Unfortunately, we have changes in our fork that are not present upstream so we cannot accept this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants