Skip to content

Comments

fix(ci): Resolve mypy strict typing errors and pylint issues#14

Open
laciferin2024 wants to merge 6 commits intostoracha:mainfrom
laciferin2024:chore/fix-ci
Open

fix(ci): Resolve mypy strict typing errors and pylint issues#14
laciferin2024 wants to merge 6 commits intostoracha:mainfrom
laciferin2024:chore/fix-ci

Conversation

@laciferin2024
Copy link

@laciferin2024 laciferin2024 commented Jan 26, 2026

Fixes CI failures by resolving 61 mypy strict typing errors and 3 pylint errors in the actress module.

Changes

  • Type Safety: Refactored Task and Controller to use proper Protocol definitions
  • Modern Typing: Updated generic type annotations to use PEP 695 syntax where appropriate
  • Generator Protocols: Fixed iter, send(), throw(), and return_() signatures to properly match typing.Generator
  • Error Handling: Added proper type annotations throughout task.py and lib.py
  • Linting: Suppressed false-positive pylint errors for generator iteration

Verification

  • mypy --strict actress - Passes with 0 errors
  • pylint --errors-only - Passes with 0 errors
  • pytest - All tests passing

Compatibility

Maintains backward compatibility with Python 3.9+

Hiro added 2 commits January 26, 2026 06:19
… removing dead code and updating core task model imports.
@laciferin2024 laciferin2024 marked this pull request as draft January 26, 2026 01:05
@laciferin2024 laciferin2024 marked this pull request as ready for review January 26, 2026 01:24
@laciferin2024 laciferin2024 changed the title chore: fix ci fix(ci): Resolve mypy strict typing errors and pylint issues Jan 26, 2026
@laciferin2024 laciferin2024 changed the title fix(ci): Resolve mypy strict typing errors and pylint issues feat: port js implementation to python Jan 26, 2026
@laciferin2024 laciferin2024 changed the title feat: port js implementation to python fix(ci): Resolve mypy strict typing errors and pylint issues Jan 26, 2026
@laciferin2024
Copy link
Author

I am a fellow PDLG contributor, requesting for a review : @alanshaw @0-th

@0-th
Copy link

0-th commented Feb 9, 2026

hi @laciferin2024 , apologies for not reviewing this earlier and great work here as well.

but could you make this PR to my fork of the repo here so it's clearer what changes you're making to the implementation. also, note that my latest changes are in the dev branch not main.

@laciferin2024
Copy link
Author

I need #13 merged first. Currently I have stabilized my branch with main and even fixed the ci issues. As the author of #13, @0-th can u please move the pr from draft to "ready for review" ..

@0-th
Copy link

0-th commented Feb 9, 2026

@laciferin2024 I'd for sure move the PR to ready for review once I fix the 3 deadlocking tests in the implementation.

I'm just suggesting that your PR would be much easier to review if it was opened on my fork instead, since you're trying to fix typing and linting issues in the implementation that's currently not on this repo but on my fork.

That way I can clearly see the changes you're suggesting against the implementation to fix these errors.

Made similar comments here on a similar PR.

Once your contribution and commits are reviewed and gets merged into the #13 then it can be cleanly reviewed and merged by @alanshaw .

is this clearer @laciferin2024 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants