fix(ci): Resolve mypy strict typing errors and pylint issues#14
fix(ci): Resolve mypy strict typing errors and pylint issues#14laciferin2024 wants to merge 6 commits intostoracha:mainfrom
Conversation
… removing dead code and updating core task model imports.
|
hi @laciferin2024 , apologies for not reviewing this earlier and great work here as well. but could you make this PR to my fork of the repo here so it's clearer what changes you're making to the implementation. also, note that my latest changes are in the dev branch not main. |
|
@laciferin2024 I'd for sure move the PR to ready for review once I fix the 3 deadlocking tests in the implementation. I'm just suggesting that your PR would be much easier to review if it was opened on my fork instead, since you're trying to fix typing and linting issues in the implementation that's currently not on this repo but on my fork. That way I can clearly see the changes you're suggesting against the implementation to fix these errors. Made similar comments here on a similar PR. Once your contribution and commits are reviewed and gets merged into the #13 then it can be cleanly reviewed and merged by @alanshaw . is this clearer @laciferin2024 ? |
Fixes CI failures by resolving 61 mypy strict typing errors and 3 pylint errors in the actress module.
Changes
typing.GeneratorVerification
mypy --strict actress- Passes with 0 errorspylint --errors-only- Passes with 0 errorspytest- All tests passingCompatibility
Maintains backward compatibility with Python 3.9+