This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
feat: [SPMVP -6521] use typesense to fetch article list in karbon to reduce api server load #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanSnow
suggested changes
Oct 9, 2023
| const getPage = async (page: number) => { | ||
| const { data } = await client.query({ query, variables: { page } }) | ||
| return data.articles | ||
| const documents = typesenseClient?.collections('articles').documents() |
There was a problem hiding this comment.
目前不確定為什麼，在測試 sitemap 與 feed 時速度比起 front page 要來的慢很多，有辦法確定原因嗎？
There was a problem hiding this comment.
調整作法為使用 payload 作為資料來源
|
|
||
| export const PER_PAGE = 100 | ||
|
|
||
| export function getSearchQuery(page = 1, filter: TypesenseFilter = {}) { |
| filter_by: filterBy, | ||
| per_page: PER_PAGE, | ||
| page, | ||
| preset: `list-articles-${page}`, |
There was a problem hiding this comment.
💭 這個 preset 好像用法不太對，這邊應該不需要 https://typesense.org/docs/0.25.1/api/search.html#presets
There was a problem hiding this comment.
已經修正，因為型別錯誤誤以為這是必要屬性，但原因是我有漏掉其他必要屬性才會顯示缺少 preset
SidStraw
force-pushed
the
SPMVP-6521-use-typesense-to-fetch-article-list-in-karbon-to-reduce-api-server-load
branch
from
77dc9ed to
9639cef
Compare
DanSnow
suggested changes
Oct 12, 2023
|
透過其他專案驗證：
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/sitemap.xmlis functioning correctly./atom.xmlis working as expected.filter_byfeature.