This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
fix: [SPMVP-6809] support custom tailwind config for karbon cli #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidStraw
force-pushed
the
SPMVP-6809-cannot-execute-yarn-karbon-pack-only-in-briefstory-repo
branch
from
07ea16e to
51045ee
Compare
SidStraw
commented
Nov 28, 2023
| const packageJson = require(path.resolve(tempPath, './package.json')) | ||
| const version = packageJson?.packageManager?.split?.('@')?.[1] || 'berry' | ||
|
|
||
| await $$`yarn set version ${version}` |
There was a problem hiding this comment.
這邊因為 yarn set version berry 會設置為 yarn 4.0
可能與專案設定相衝突而導致錯誤
| darkMode: ['class', '.force-use-dark-mode'], | ||
| }, | ||
| ], | ||
| config: tailwindConfigPath, |
There was a problem hiding this comment.
測試後發現 require(tailwindConfigPath) 沒有正確載入組態，因此改回使用 config: tailwindConfigPath 設定
SidStraw
force-pushed
the
SPMVP-6809-cannot-execute-yarn-karbon-pack-only-in-briefstory-repo
branch
from
290f992 to
42f1d40
Compare
DanSnow
changed the title
yarn karbon --pack-only in Briefstory repo
DanSnow
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://storipress-media.atlassian.net/browse/SPMVP-6809
相關 PR： https://github.com/storipress/manager-next/pull/2085
驗證：可正確上傳