Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PRO-615 push pull tag components #114

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

alvarosabu
Copy link
Contributor

Pull request type

Allow CLI to push components with tags

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

How to test this PR

  • Build project locally with npm run build
  • Create a component with tags on Space A
  • Pull components of source Space A with node dist/cli.mjs pull-components --space=spaceAid
  • Push components to Space B with node dist/cli.mjs push-components componentsSpaceAid.json --space=spaceBid

You should see this:

Screenshot 2024-09-12 at 10 39 15

What is the new behavior?

Other information

@alvarosabu alvarosabu added p4-important [Priority] Violate documented behavior or significantly improve performance (priority) bugfix [PR] Fixes a bug labels Sep 12, 2024
@alvarosabu alvarosabu self-assigned this Sep 12, 2024
@alvarosabu alvarosabu changed the title fix: pro 615 push pull tag components fix: PRO-615 push pull tag components Sep 12, 2024
Copy link
Contributor

@Edo-San Edo-San left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the fix @alvarosabu! 🙏

@alvarosabu alvarosabu merged commit 5f3f2b1 into master Sep 12, 2024
1 check failed
Copy link

🎉 This PR is included in version 3.33.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix [PR] Fixes a bug p4-important [Priority] Violate documented behavior or significantly improve performance (priority) released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants