-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull-components
: options to include datasource values
#90
pull-components
: options to include datasource values
#90
Conversation
f8cc509
to
78943d7
Compare
what's the status of this? |
Hey @ademarCardoso, are the team happy with this work and the possibility of it being merged? It's something that would really improve typing, thanks! |
I will share this PR with the management and lets see what we can do here, thanks for tagging me @tomsansome 😄 @RKcode Could you please check the conflicts ? Many thanks guys 🚀 |
Hi @RKcode thanks a lot for this PR, would you be so kind as to resolve the conflicts present? That way I can download your fork and test it. Thanks! |
3af4f4a
to
31fe037
Compare
…ltiple option field
31fe037
to
e8c9322
Compare
Hey @alvarosabu ! I fixed the conflicts, should be good to test/review 👍 |
Is there any news about this? This might be able to solve an issue I just opened. |
Small 🆙 @alvarosabu @ademarCardoso |
Hi, @RKcode thanks for opening this PR, I need to test it before we merge it, we also need to update the readme with the new option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it and works as expected. Thank you very much for the great PR @RKcode
🎉 This PR is included in version 3.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull request type
Jira Link: INT-
How to test this PR
Use the option
--resolve-datasources
/--rb
What is the new behavior?
Other information
Solve this #48