Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull-components: options to include datasource values #90

Merged

Conversation

RKcode
Copy link
Contributor

@RKcode RKcode commented Apr 8, 2024

Pull request type

Jira Link: INT-

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

How to test this PR

Use the option --resolve-datasources/--rb

What is the new behavior?

  • Fetch datasources & datasource_entries
  • Map those to component options

Other information

Solve this #48

@RKcode RKcode force-pushed the feat/resolve-datasources-option-field branch from f8cc509 to 78943d7 Compare April 8, 2024 13:57
@merisbahti
Copy link

what's the status of this?

@tomsansome
Copy link

Hey @ademarCardoso, are the team happy with this work and the possibility of it being merged? It's something that would really improve typing, thanks!

@ademarCardoso
Copy link
Member

I will share this PR with the management and lets see what we can do here, thanks for tagging me @tomsansome 😄

@RKcode Could you please check the conflicts ?

Many thanks guys 🚀

@alexjoverm alexjoverm requested review from alvarosabu and alexjoverm and removed request for alexjoverm August 29, 2024 06:44
@alvarosabu
Copy link
Contributor

Hi @RKcode thanks a lot for this PR, would you be so kind as to resolve the conflicts present? That way I can download your fork and test it.

Thanks!

@RKcode RKcode force-pushed the feat/resolve-datasources-option-field branch 2 times, most recently from 3af4f4a to 31fe037 Compare September 3, 2024 10:18
@RKcode RKcode force-pushed the feat/resolve-datasources-option-field branch from 31fe037 to e8c9322 Compare September 3, 2024 10:19
@RKcode
Copy link
Contributor Author

RKcode commented Sep 3, 2024

Hey @alvarosabu !
Thx for the answer, sorry I totally forgot that I contributed here

I fixed the conflicts, should be good to test/review 👍

@TwoBee
Copy link

TwoBee commented Sep 24, 2024

Is there any news about this? This might be able to solve an issue I just opened.

@RKcode
Copy link
Contributor Author

RKcode commented Sep 24, 2024

Small 🆙 @alvarosabu @ademarCardoso
Tell me if you guys need anything else from me on this topic. I'll try to be reactive if there are any changes required after the review 👍

@alvarosabu alvarosabu added p3-significant [Priority] Moderate issues, major enhancements feature [Issue] New feature or request needs-documentation [PR] Changes lacking sufficient documentation labels Oct 7, 2024
@alvarosabu alvarosabu self-assigned this Oct 7, 2024
@alvarosabu
Copy link
Contributor

Hi, @RKcode thanks for opening this PR, I need to test it before we merge it, we also need to update the readme with the new option.

@alvarosabu alvarosabu removed the needs-documentation [PR] Changes lacking sufficient documentation label Oct 15, 2024
Copy link
Contributor

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it and works as expected. Thank you very much for the great PR @RKcode

Screenshot 2024-10-15 at 10 08 30

@alvarosabu alvarosabu merged commit 82f4e28 into storyblok:master Oct 15, 2024
1 check failed
Copy link

🎉 This PR is included in version 3.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [Issue] New feature or request p3-significant [Priority] Moderate issues, major enhancements released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants