Chore: Upgrade to support Storybook 7.0 #8

senicar · 2023-03-23T06:32:46Z

Hi, this is my first time contributing to storybook addon code, so I would appreciate any guidance to improve this PR fix and to make it more inline with Storybook codestyle and principles.

This is a fix to make CSS Resources addon work on Storybook v7.0.

What have I done:

Installed next version of Storybook
Added React 18 to permitted peerDependencies
Added "Modern browser support" as described in https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#modern-browser-support
Fixed undefined "document" error by updating import { document } from 'global';
Fixed implicit any eslint error for storyOptions

How I tested:

I have validated that it works with npm run storybook
I have created a local package to test it in a custom Storybook v7.0 build

What does not work:

Due to changes, addon does not work in Storybook 6 anymore

socket-security · 2023-03-23T06:34:50Z

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package	Script field	Source
core-js-pure@3.29.1 (upgraded)	`postinstall`	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
esbuild@0.16.17 (added)	`postinstall`	`package.json` via @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6

😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package	Bin script	Source
@storybook/cli@7.0.0-rc.6 (added)	`sb`	`package.json` via storybook@7.0.0-rc.6
storybook@7.0.0-rc.6 (added)	`sb`	`package.json`

⚠️ Shell access

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Package	Module	Location	Source
@auto-it/core@10.43.0 (upgraded)	child_process	dist/tests/auto-make-changelog.test.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/tests/auto.test.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/tests/get-current-branch.test.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/tests/get-remote.test.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/tests/release.test.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/auto.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/release.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/utils/tests/load-plugin.test.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/utils/tests/verify-auth.test.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/utils/exec-promise.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/utils/get-current-branch.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/utils/load-plugins.js	`package.json` via auto@10.43.0
@auto-it/core@10.43.0 (upgraded)	child_process	dist/utils/verify-auth.js	`package.json` via auto@10.43.0
@auto-it/npm@10.43.0 (upgraded)	child_process	dist/index.js	`package.json` via auto@10.43.0
@aw-web-design/x-default-browser@1.4.88 (added)	child_process	src/detect-linux.js	`package.json` via storybook@7.0.0-rc.6
@aw-web-design/x-default-browser@1.4.88 (added)	child_process	src/detect-windows.js	`package.json` via storybook@7.0.0-rc.6
@aw-web-design/x-default-browser@1.4.88 (added)	child_process	src/detect-windows10.js	`package.json` via storybook@7.0.0-rc.6
@storybook/cli@7.0.0-rc.6 (added)	child_process	dist/generate.js	`package.json` via storybook@7.0.0-rc.6
@storybook/telemetry@7.0.0-rc.6 (added)	child_process	dist/index.js	`package.json` via storybook@7.0.0-rc.6
@storybook/telemetry@7.0.0-rc.6 (added)	child_process	dist/index.mjs	`package.json` via storybook@7.0.0-rc.6
address@1.2.2 (upgraded)	child_process	lib/address.js	`package.json` via storybook@7.0.0-rc.6
better-opn@2.1.1 (added)	child_process	dist/index.js	`package.json` via storybook@7.0.0-rc.6
commander@2.20.3 (added)	child_process	index.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, babel-loader@8.3.0
cross-spawn@7.0.3 (added)	child_process	index.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, auto@10.43.0, storybook@7.0.0-rc.6
envinfo@7.8.1 (added)	child_process	dist/envinfo.js	`package.json` via storybook@7.0.0-rc.6
esbuild@0.16.17 (added)	child_process	install.js	`package.json` via @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
esbuild@0.16.17 (added)	child_process	lib/main.js	`package.json` via @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
execa@5.1.1 (upgraded)	child_process	index.js	`package.json` via auto@10.43.0, storybook@7.0.0-rc.6
gitlog@4.0.4 (added)	child_process	dist/gitlog.cjs.development.js	`package.json` via auto@10.43.0
gitlog@4.0.4 (added)	child_process	dist/gitlog.cjs.production.min.js	`package.json` via auto@10.43.0
gitlog@4.0.4 (added)	child_process	dist/gitlog.esm.js	`package.json` via auto@10.43.0
jake@10.8.5 (added)	child_process	jake-v10.8.5/jakefile.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/lib/package_task.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/lib/publish_task.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/lib/utils/index.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/test/integration/concurrent.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/test/integration/file_task.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/test/integration/file.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/test/integration/helpers.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/test/integration/jakelib/rule.jake.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/test/integration/publish_task.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/test/integration/rule.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/test/integration/selfdep.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/test/integration/task_base.js	`package.json` via storybook@7.0.0-rc.6
jake@10.8.5 (added)	child_process	jake-v10.8.5/test/integration/task_base.js	`package.json` via storybook@7.0.0-rc.6
jest-worker@27.5.1 (upgraded)	child_process	build/workers/ChildProcessWorker.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, babel-loader@8.3.0
jscodeshift@0.14.0 (added)	child_process	dist/Runner.js	`package.json` via storybook@7.0.0-rc.6
jscodeshift@0.14.0 (added)	child_process	src/Runner.js	`package.json` via storybook@7.0.0-rc.6
open@7.4.2 (added)	child_process	index.js	`package.json` via storybook@7.0.0-rc.6
open@8.4.2 (added)	child_process	index.js	`package.json` via storybook@7.0.0-rc.6
puppeteer-core@2.1.1 (added)	child_process	lib/Launcher.js	`package.json` via storybook@7.0.0-rc.6
requireg@0.2.2 (added)	child_process	lib/resolvers.js	`package.json` via auto@10.43.0
shelljs@0.8.5 (added)	child_process	src/exec-child.js	`package.json` via storybook@7.0.0-rc.6
shelljs@0.8.5 (added)	child_process	src/exec.js	`package.json` via storybook@7.0.0-rc.6
tree-kill@1.2.2 (added)	child_process	index.js	`package.json` via concurrently@5.3.0
ts-node@10.9.1 (added)	child_process	dist/child/spawn-child.js	`package.json` via auto@10.43.0
typescript@4.9.5 (upgraded)	child_process	lib/tsserver.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, auto@10.43.0
typescript@4.9.5 (upgraded)	child_process	lib/tsserver.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, auto@10.43.0
typescript@4.9.5 (upgraded)	child_process	lib/typingsInstaller.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, auto@10.43.0
update-browserslist-db@1.0.10 (added)	child_process	check-npm-version.js	`package.json` via @babel/cli@7.21.0, @babel/core@7.21.3, @babel/preset-env@7.20.2, @babel/preset-react@7.18.6, @babel/preset-typescript@7.21.0, @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, babel-loader@8.3.0, storybook@7.0.0-rc.6
update-browserslist-db@1.0.10 (added)	child_process	index.js	`package.json` via @babel/cli@7.21.0, @babel/core@7.21.3, @babel/preset-env@7.20.2, @babel/preset-react@7.18.6, @babel/preset-typescript@7.21.0, @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, babel-loader@8.3.0, storybook@7.0.0-rc.6

⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package	Eval Type	Location	Source
@storybook/components@7.0.0-rc.6 (upgraded)	Function	dist/formatter-UT3ZCDIS.mjs	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/components@7.0.0-rc.6 (upgraded)	Function	dist/formatter-UT3ZCDIS.mjs	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/docs-mdx@0.0.1-next.6 (added)	Function	dist/index.mjs	`package.json` via storybook@7.0.0-rc.6
@storybook/manager@7.0.0-rc.6 (added)	Function	dist/chunk-ZOUMJK5U.mjs	`package.json` via storybook@7.0.0-rc.6
@storybook/manager@7.0.0-rc.6 (added)	Function	dist/chunk-ZOUMJK5U.mjs	`package.json` via storybook@7.0.0-rc.6
@storybook/manager@7.0.0-rc.6 (added)	Function	dist/chunk-ZOUMJK5U.mjs	`package.json` via storybook@7.0.0-rc.6
@storybook/manager@7.0.0-rc.6 (added)	Function	dist/chunk-ZOUMJK5U.mjs	`package.json` via storybook@7.0.0-rc.6
@storybook/manager@7.0.0-rc.6 (added)	Function	dist/chunk-ZOUMJK5U.mjs	`package.json` via storybook@7.0.0-rc.6
@storybook/manager@7.0.0-rc.6 (added)	Function	dist/chunk-ZOUMJK5U.mjs	`package.json` via storybook@7.0.0-rc.6
@storybook/manager@7.0.0-rc.6 (added)	Function	dist/chunk-ZOUMJK5U.mjs	`package.json` via storybook@7.0.0-rc.6
@storybook/manager@7.0.0-rc.6 (added)	Function	dist/formatter-UT3ZCDIS-52LVTYWQ.mjs	`package.json` via storybook@7.0.0-rc.6
@storybook/manager@7.0.0-rc.6 (added)	Function	dist/formatter-UT3ZCDIS-52LVTYWQ.mjs	`package.json` via storybook@7.0.0-rc.6
@storybook/preview@7.0.0-rc.6 (added)	Function	dist/runtime.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/preview@7.0.0-rc.6 (added)	Function	dist/runtime.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/preview@7.0.0-rc.6 (added)	Function	dist/runtime.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/preview@7.0.0-rc.6 (added)	Function	dist/runtime.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/preview@7.0.0-rc.6 (added)	Function	dist/runtime.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/preview@7.0.0-rc.6 (added)	Function	dist/runtime.mjs	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/preview@7.0.0-rc.6 (added)	Function	dist/runtime.mjs	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/preview@7.0.0-rc.6 (added)	Function	dist/runtime.mjs	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/preview@7.0.0-rc.6 (added)	Function	dist/runtime.mjs	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/preview@7.0.0-rc.6 (added)	Function	dist/runtime.mjs	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
@storybook/router@7.0.0-rc.6 (upgraded)	Function	dist/chunk-NQZQ3SVL.mjs	`package.json` via @storybook/addons@7.0.0-rc.6, @storybook/api@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6
@storybook/router@7.0.0-rc.6 (upgraded)	Function	dist/index.js	`package.json` via @storybook/addons@7.0.0-rc.6, @storybook/api@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6
@storybook/router@7.0.0-rc.6 (upgraded)	Function	dist/utils.js	`package.json` via @storybook/addons@7.0.0-rc.6, @storybook/api@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6
ajv@6.12.6 (added)	Function	dist/ajv.bundle.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, babel-loader@8.3.0
ajv@6.12.6 (added)	Function	lib/compile/index.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, babel-loader@8.3.0
ajv@8.12.0 (added)	Function	dist/compile/index.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
ajv@8.12.0 (added)	Function	dist/compile/jtd/parse.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
core-js-pure@3.29.1 (upgraded)	Function	internals/async-iterator-prototype.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6
depd@2.0.0 (upgraded)	Function	index.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
ejs@3.1.9 (added)	Function	ejs-v3.1.9/ejs.js	`package.json` via storybook@7.0.0-rc.6
ejs@3.1.9 (added)	Function	ejs-v3.1.9/ejs.js	`package.json` via storybook@7.0.0-rc.6
ejs@3.1.9 (added)	Function	ejs-v3.1.9/ejs.min.js	`package.json` via storybook@7.0.0-rc.6
ejs@3.1.9 (added)	Function	ejs-v3.1.9/ejs.min.js	`package.json` via storybook@7.0.0-rc.6
ejs@3.1.9 (added)	Function	ejs-v3.1.9/lib/ejs.js	`package.json` via storybook@7.0.0-rc.6
ejs@3.1.9 (added)	Function	ejs-v3.1.9/lib/ejs.js	`package.json` via storybook@7.0.0-rc.6
envinfo@7.8.1 (added)	Function	dist/envinfo.js	`package.json` via storybook@7.0.0-rc.6
envinfo@7.8.1 (added)	Function	dist/envinfo.js	`package.json` via storybook@7.0.0-rc.6
esbuild-register@3.4.2 (added)	Function	dist/node.js	`package.json` via @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
handlebars@4.7.7 (added)	Function	dist/cjs/handlebars/compiler/javascript-compiler.js	`package.json` via @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
handlebars@4.7.7 (added)	Function	dist/cjs/handlebars/compiler/javascript-compiler.js	`package.json` via @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
handlebars@4.7.7 (added)	Function	dist/handlebars.amd.js	`package.json` via @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
handlebars@4.7.7 (added)	Function	dist/handlebars.amd.js	`package.json` via @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
handlebars@4.7.7 (added)	Function	dist/handlebars.amd.min.js	`package.json` via @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
handlebars@4.7.7 (added)	Function	dist/handlebars.amd.min.js	`package.json` via @storybook/react@7.0.0-rc.6, @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
is-callable@1.2.7 (upgraded)	Function	test/index.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
is-callable@1.2.7 (upgraded)	Function	test/index.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
is-generator-function@1.0.10 (added)	Function	index.js	`package.json` via @storybook/react-webpack5@7.0.0-rc.6, storybook@7.0.0-rc.6
lodash@4.17.21 (added)	Function	_root.js	[`package.json`](https://github.com/storybookjs/addon-cssresources/pull/8/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d

Chore: Upgrade to support Storybook 7.0

3ee284e

senicar force-pushed the update-to-storybook-v7 branch from 75e2699 to 3ee284e Compare March 23, 2023 06:47

Limit storybook peerDependencies to v7.0 only

069f3b9

EliezerB123 mentioned this pull request Aug 4, 2024

Use the new Framework API #7

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Chore: Upgrade to support Storybook 7.0 #8

Chore: Upgrade to support Storybook 7.0 #8

Uh oh!

senicar commented Mar 23, 2023

Uh oh!

socket-security bot commented Mar 23, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Chore: Upgrade to support Storybook 7.0 #8

Are you sure you want to change the base?

Chore: Upgrade to support Storybook 7.0 #8

Uh oh!

Conversation

senicar commented Mar 23, 2023

Uh oh!

socket-security bot commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Socket Security Pull Request Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

socket-security bot commented Mar 23, 2023 •

edited

Loading