feat: add buttons to hide/show ui #632
Open
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlow92
reviewed
Oct 26, 2024
| import { useTheme } from '@storybook/react-native-theming'; | ||
|
|
||
| export function FullscreenIcon({ | ||
| color, //= '#2E3438', |
There was a problem hiding this comment.
I guess this is a missed debug statement?
| borderWidth: 1, | ||
| borderColor: theme.appBorderColor, | ||
| }} | ||
| onPress={() => setUiHidden(!uiHidden)} |
There was a problem hiding this comment.
Even though we don't have any other calls of setUiHidden so it should not be a problem. I would suggest using function setter for toggling.
Suggested change
| onPress={() => setUiHidden(!uiHidden)} | |
| onPress={() => setUiHidden(prev => !prev)} |
| <TouchableOpacity | ||
| style={{ | ||
| position: 'absolute', | ||
| bottom: uiHidden ? 56 + insets.bottom : 16, |
There was a problem hiding this comment.
I think in the future it might be useful to make it draggable (like android notification bubbles), in case it overlaps with buttons of a story component.
Comment on lines
+157
to
+159
| <CloseFullscreenIcon color={theme.color.mediumdark} /> | ||
| ) : ( | ||
| <FullscreenIcon color={theme.color.mediumdark} /> |
There was a problem hiding this comment.
Probably it's better to use theme.background.content.
Otherwise it does not respeect browsers darkmode, right?
|
thanks for all the feedback @tlow92 I definitely apply those and iterate a bit further to see what I can come up with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
How to test
Please explain how to test your changes and consider the following questions
If your answer is yes to any of these, please make sure to include it in your PR.