Add support to use import members from CSV file Add On combined with … #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Group accounts Add On * Hook into after import action to insert parent and child accounts.
* Rename hook callback function name * Add few WPCS tweaks.
* cast to int values to insert, the same way the addon does in other places
…Group accounts Add On * Hook into after import action to insert parent and child accounts.
* Rename hook callback function name * Add few WPCS tweaks.
* cast to int values to insert, the same way the addon does in other places
If owner is passed is a child account
MaximilianoRicoTabo
force-pushed
the
enhancement/add-support-for-IUFCSV
branch
from
9ad648b to
439e9ea
Compare
…github.com/MaximilianoRicoTabo/pmpro-group-accounts into pr/31" This reverts commit 71b7b67, reversing changes made to 9ad648b.
dparker1005
force-pushed
the
enhancement/add-support-for-IUFCSV
branch
from
5225b7e to
71b7b67
Compare
* Change aproach to just update seats for group accounts * Create Group Member account if the level can be claimed with a code.
* Reworked import members from CSV logic.
dparker1005
reviewed
Jul 12, 2024
| $group_level_settings = pmprogroupacct_get_settings_for_level( $membership_id ); | ||
| $parent_group = PMProGroupAcct_Group::get_group_by_parent_user_id_and_parent_level_id( $user->ID, $membership_id ); | ||
| $group_id = $user->pmprogroupacct_group_id; // Child accounts would pass through the Group ID. | ||
| $seats = ! empty( $user->pmprogroupacct_group_total_seats ) ? intval( $user->pmprogroupacct_group_total_seats ) : $group_level_settings['max_seats']; |
There was a problem hiding this comment.
Do we always want to default to the max seats for a group, or if the number of seats is not specified, do we instead just not want to alter group seat data?
dparker1005
reviewed
Jul 12, 2024
| if ( ! empty( $parent_group ) ) { | ||
| //Update seats if the user has a total seats value from CSV. | ||
| $parent_group->update_group_total_seats( $seats ); | ||
| } elseif ( empty( $group_id ) ) { |
There was a problem hiding this comment.
This is tricky. I think we only want to create a new group if:
- The level being imported is a group level
- The number of seats for the group to be created with is specified
PixelsIng
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Hi,
I can't find the required csv structure for using this code.
Can you help me ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Group accounts Add On
All Submissions:
Changes proposed in this Pull Request:
Resolves #30 .
How to test the changes in this Pull Request:
Other information:
Changelog entry