Fix: render empty paragraph as br elements #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It catches all the empty paragraphs and renders them as br elements
Why is it needed?
With the previous implementation every time we had a new line was rendered as an empty paragraph
How to test it?
In a frontend app, use the renderer (link it via yarn), and pass a content like this for example
[ { type: 'paragraph', children: [{ type: 'text', text: 'First paragraph' }], }, // empty paragraph { type: 'paragraph', children: [{ type: 'text', text: '' }], }, { type: 'paragraph', children: [{ type: 'text', text: 'Second paragraph' }], }, ]
Related issue(s)/PR(s)
This PR solve this issue #12