Open
Conversation
Member
|
Hi @SowmyakumarSow , |
Author
|
You can review spaceX itself. |
Author
|
Hi,
ignore the previous mail.
you can verify #2
itself.
Regards,
Sowmya M
…On Tue, Aug 9, 2022 at 12:16 AM sri sow ***@***.***> wrote:
hi please check
https://github.com/stratforge/react-code-challenge/pull/2/files
and this branch contains only css and minimal code formatting changes. but
i am unable to create a PR for this.
if I create a PR. will share it with you
master...SowmyakumarSow:react-code-challenge:spaceX
On Sun, Aug 7, 2022 at 10:56 PM Rejo Chandran ***@***.***>
wrote:
> Hi @SowmyakumarSow <https://github.com/SowmyakumarSow> ,
> Thanks for the PR. Few
> Since this is just a questions repo, we'll review the code on your fork
> and also upon checking your fork, we see that master is ahead of spaceX
> branch. Please confirm and let us know which branch we can use for the code
> review.
>
> —
> Reply to this email directly, view it on GitHub
> <#2 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AIW6AMRMX55J6NWKIY5KBLDVX7WTFANCNFSM552YAWKQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Member
|
@SowmyakumarSow |
Author
|
hi please check
https://github.com/stratforge/react-code-challenge/pull/2/files
and this branch contains only css and minimal code formatting changes. but
i am unable to create a PR for this.
if I create a PR. will share it with you
master...SowmyakumarSow:react-code-challenge:spaceX
…On Sun, Aug 7, 2022 at 10:56 PM Rejo Chandran ***@***.***> wrote:
Hi @SowmyakumarSow <https://github.com/SowmyakumarSow> ,
Thanks for the PR. Few
Since this is just a questions repo, we'll review the code on your fork
and also upon checking your fork, we see that master is ahead of spaceX
branch. Please confirm and let us know which branch we can use for the code
review.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIW6AMRMX55J6NWKIY5KBLDVX7WTFANCNFSM552YAWKQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic web app creation using react and react-redux.
used react-toolkit for the redux flow.
Test cases for components are created.