Make stratis-legacy-pool a command of stratisd-tools #3752
Conversation
mulkieran
force-pushed
the
add-legacy-to-stratisd-tools
branch
4 times, most recently
from
b6c3796 to
b0eb73a
Compare
If the possible values exist, they will appear in the usage message if the user enters a wrong executable value. To make them not appear at all there should be no list of possible values. A subsequent expression will verify that the name entered is a valid one. Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
add-legacy-to-stratisd-tools
branch
from
b0eb73a to
82a7fca
Compare
mulkieran
force-pushed
the
add-legacy-to-stratisd-tools
branch
2 times, most recently
from
6b75322 to
761bb69
Compare
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
2 similar comments
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
mulkieran
force-pushed
the
add-legacy-to-stratisd-tools
branch
from
761bb69 to
4319609
Compare
Cargo.toml
Outdated
| min = ["dep:termios"] | ||
| systemd_compat = ["dep:bindgen"] | ||
| udev_scripts = ["dep:data-encoding"] | ||
| test_extras = ["engine"] | ||
| test_extras = [] |
There was a problem hiding this comment.
Are we leaving this for packaging?
There was a problem hiding this comment.
The one good reason for leaving this in was not having to update the spec file. So, yes, it was for packaging convenience. If we change it, we change the spec file. But that is no big deal, really, except that it could break the Packit/TMT structure briefly. But, we can work around that.
There was a problem hiding this comment.
Actually, I don't even think it was for packaging. I'll see about removing it.
|
Packages worked. Tests would have failed anyway, because of necessity to respond yes. |
mulkieran
force-pushed
the
add-legacy-to-stratisd-tools
branch
from
3a546b8 to
ddb62e5
Compare
|
@jbaublitz This is ready again. |
Signed-off-by: mulhern <amulhern@redhat.com>
It is possible to use the extras feature only, since it the test_extras code is always going to be included with the extras code. Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
add-legacy-to-stratisd-tools
branch
from
ddb62e5 to
cddb8d1
Compare
No description provided.